Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Objects/**Dto.php less strictly #21

Open
hackoh opened this issue Feb 7, 2024 · 3 comments
Open

Make Objects/**Dto.php less strictly #21

hackoh opened this issue Feb 7, 2024 · 3 comments

Comments

@hackoh
Copy link
Contributor

hackoh commented Feb 7, 2024

Currently riot adds properties to Dto very often.
When they add some, this driver don't work because of "Property *** does not exist" error.

@dolejska-daniel
Copy link
Owner

There actually is a project which can create the data classes from Riot API endpoint documentation. You can find it here: https://github.com/dolejska-daniel/riot-api-docs_parser

@hackoh
Copy link
Contributor Author

hackoh commented Mar 13, 2024

@dolejska-daniel
The problem is that Riot eventually adds new properties undocumented.
I don't want this driver to be vulnerable against undocumented changing.
At least the driver have to be able to run.

@dolejska-daniel
Copy link
Owner

Damn 😄 Well, it will be best to make DTO instance population not so strict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants