Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Torii is not returning indexing error even though it hasn't fully indexed data #2811

Open
steebchen opened this issue Dec 16, 2024 · 4 comments · Fixed by #2827
Open
Labels
bug Something isn't working torii

Comments

@steebchen
Copy link
Contributor

image

In the beginning, it returns:

{
  "errors": [
    {
      "message": "World does not have any indexed data yet."
    }
  ]
}

which is good. However, at some point, the message disappears, even though the data is not fully indexed yet. Some data is returned but it takes another plenty of minutes. Maybe this might be due to the data not fully being written do the db yet?

@steebchen steebchen added the bug Something isn't working label Dec 16, 2024
@glihm glihm added the torii label Dec 16, 2024
@Larkooo
Copy link
Collaborator

Larkooo commented Dec 20, 2024

We show that error when there are 0 models indexed yet. The error disappears when at least 1 model has been indexed. So it isnt supposed for the world to be fully indexed, because anyway indexing is not finite. I can get rid of the error though ig, as it is a bit confusing

@steebchen
Copy link
Contributor Author

Makes sense. Is there a way to know when the initial indexing is done? That would be very helpful when scaling up a cluster of torii replicas

@glihm
Copy link
Collaborator

glihm commented Dec 21, 2024

Makes sense. Is there a way to know when the initial indexing is done? That would be very helpful when scaling up a cluster of torii replicas

This should be something we can have yeah, when torii is indexing the pending block and not historical blocks. We already have in the database this info with the contracts heads @Larkooo right? Maybe in an other PR we could expose this info in a similar manner to the syncing endpoint of the starknet API where we can query the syncing state of a node.

@steebchen
Copy link
Contributor Author

#2827 just removes the message but doesn't implement the full solution we've talked above right?

@steebchen steebchen reopened this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working torii
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants