-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previous Messages Resent to L1 on Katana Restart #2033
Comments
@kariy would have any pointer on that one? |
Hi, can I get assigned to this? |
This seemed to be caused by the messaging service not having context of where to start the message processing. dojo/crates/katana/core/src/service/messaging/service.rs Lines 65 to 69 in 30e9803
For gathering the messages from the L1, we have an item in the configuration that may be used for that. However, as we're using a database, this block number may be different if Katana stops without graceful shutdown. Currently, on the providers traits we have, there's no trait to store messaging information (last block gathered, last block sent messages). @kariy does it sound reasonable to add a provider trait to store such information and allow Katana to restart from an existing database being aware of which blocks must be processed for L1 <> L2 messaging? @StarkFishinator are you feeling confident to dive into that? Or do you have an other strategy to propose? |
@ybensacq we've synced with @kariy and here's the way we could solve that:
|
Describe the bug
When running Katana with the command
katana --messaging anvil.messaging.json --db-dir ./database
previously sent messages to L2 are resent to L1 upon restarting Katana.
To Reproduce
Steps to reproduce the behavior:
katana --messaging anvil.messaging.json --db-dir ./database
katana --messaging anvil.messaging.json --db-dir ./database
(wait for a few seconds)Expected behavior
Messages should not be resent to L1 upon restarting Katana; the state should persist correctly between restarts.
The text was updated successfully, but these errors were encountered: