Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torii client compile error when importing v1.0.0-alpha.3 release #2225

Closed
elton-cs opened this issue Jul 29, 2024 · 2 comments
Closed

Torii client compile error when importing v1.0.0-alpha.3 release #2225

elton-cs opened this issue Jul 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@elton-cs
Copy link

Describe the bug
Getting the following error:

error[E0432]: unresolved import `starknet::core::types::FromStrError`
 --> /Users/zkelton/.cargo/git/checkouts/dojo-10cac2e09298cf35/a6a7724/crates/dojo-types/src/packing.rs:6:35
  |
6 | use starknet::core::types::{Felt, FromStrError};
  |                                   ^^^^^^^^^^^^
  |                                   |
  |                                   no `FromStrError` in `types`
  |                                   help: a similar name exists in the module: `FromUtf8Error`

when tagging the torii-client crate to the v1.0.0-alpha.3 release.

To Reproduce
Import torii-client in a new rust project by adding the following line to Cargo.toml under dependencies:

torii-client = { git = "https://github.com/dojoengine/dojo.git", tag = "v1.0.0-alpha.3" }

Expected behavior
Project should compile. This issue is not present on the 0.7.4 release.

Additional context
I suspect the issue comes from #2200

@elton-cs elton-cs added the bug Something isn't working label Jul 29, 2024
@elton-cs
Copy link
Author

Hey @glihm, as you mentioned, adding the following starknet-core patch into the project'sCargo.toml fixes the issue:

[patch.crates-io]
starknet-core = { git = "https://github.com/kariy/starknet-rs", branch = "dojo-patch" }

@glihm
Copy link
Collaborator

glihm commented Jul 29, 2024

Thanks for the feedback and will update when we bumped versions that don't need a patch. 👍

@glihm glihm closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants