Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]: Improve language server #1476

Closed
ponderingdemocritus opened this issue Jan 24, 2024 · 2 comments · Fixed by #2012
Closed

[core]: Improve language server #1476

ponderingdemocritus opened this issue Jan 24, 2024 · 2 comments · Fixed by #2012
Assignees
@glihm
Labels
blocked This issue is blocked due to some other issues documentation Improvements or additions to documentation dojo-core cairo core tasks
Milestone
1.0.0-alpha

Comments

@ponderingdemocritus
Copy link
Contributor

Currently the language server is not feature complete with the current Cairo version. It works, but is not ideal.

This leads to blind programming with bugs only being found after running a build. I have noticed a trend of avoiding using dojo::contracts because of this issue. Not ideal.

The language server should be inline with the Cairo language server to give the best devx.
@ponderingdemocritus ponderingdemocritus added documentation Improvements or additions to documentation dojo-core cairo core tasks labels Jan 24, 2024
@ponderingdemocritus ponderingdemocritus moved this to 🆕 Prioritized in Dojo Feb 25, 2024
@ponderingdemocritus ponderingdemocritus added this to the 1.0.0 milestone Feb 25, 2024
@glihm
Copy link
Collaborator

glihm commented Mar 7, 2024

IIRC we are coupled with Scarb for this. Will put the blocked tag until we have it unlocked by a Scarb upgrade.

@glihm glihm added the blocked This issue is blocked due to some other issues label Mar 7, 2024
@glihm glihm self-assigned this Apr 22, 2024
@glihm
Copy link
Collaborator

glihm commented Apr 22, 2024

Blocked now by #1659.

@glihm glihm mentioned this issue May 27, 2024
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Dojo May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glihm glihm

Labels
blocked This issue is blocked due to some other issues documentation Improvements or additions to documentation dojo-core cairo core tasks
Projects
No open projects
Dojo
Status: Done
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

fix: scarb bump for LS glihm/dojo
2 participants
@glihm @ponderingdemocritus