tracking: katana metrics #1369
Assignees
Labels
Comments
This was referenced Feb 14, 2024
glihm
changed the title
kariy
added
katana
Linear
kariy
added a commit
that referenced
this issue
Mar 29, 2024
ref #1369 - re-export [reth-metrics-derive](https://github.com/paradigmxyz/reth/tree/v0.2.0-beta.4/crates/metrics/metrics-derive) crate from dojo-metrics - rename metrics -> dojo-metrics crate - re-export core metrics stuff from dojo-metrics --- this PR relies on #1720 bcs reth's MSRV is 1.76.0, otherwise can't build reth-metrics-derive.
kariy
changed the title
kariy
added a commit
that referenced
this issue
Mar 30, 2024
ref #1369 add metrics for rpc server connections and methods calls
This was referenced Apr 8, 2024
kariy
added a commit
that referenced
this issue
Apr 12, 2024
ref #1369 Add metrics on katana executor; tracking the total L1 **gas** and Cairo **steps** used. There were two approaches that i thought of; 1. record the metrics on every tx execution, or 2. on every block ~Decided to go with (1) as it would allow to measure it in realtime (as the tx is being executed), instead of having to wait until the block is finished being processed.~ Thought im not exactly sure which one is the ideal one. Doing (1) might be less performant bcs we have to acquire the lock to the metrics recorder more frequently (ie every tx), as opposed to only updating the metrics once every block. another thing to note, currently doing (1) would require all executor implementations to define the metrics in their own implmentations, meaning have to duplicate code. If do (2) can just define it under `block_producer` scope and be executor agnostic. EDIT: doing (2). metrics are collected upon completion of block production --- some changes are made to gather the value after block production: - simplify params on `backend::do_mine_block`, now only accept two args; `BlockEnv` and `ExecutionOutput` - add a new type `ExecutionStats` under `katana-executor`, this is where executor would store the gas and steps value
kariy
added a commit
that referenced
this issue
Apr 12, 2024
ref #1791 #1369 <img width="1420" alt="Screenshot 2024-04-12 at 2 36 56 AM" src="https://github.com/dojoengine/dojo/assets/26515232/b97b49df-c5fc-429a-9cb0-bf66138a00b6"> showing total gas and steps using a simple line charts, tracking its growth over time
matzayonc
pushed a commit
that referenced
this issue
Apr 12, 2024
ref #1369 Add metrics on katana executor; tracking the total L1 **gas** and Cairo **steps** used. There were two approaches that i thought of; 1. record the metrics on every tx execution, or 2. on every block ~Decided to go with (1) as it would allow to measure it in realtime (as the tx is being executed), instead of having to wait until the block is finished being processed.~ Thought im not exactly sure which one is the ideal one. Doing (1) might be less performant bcs we have to acquire the lock to the metrics recorder more frequently (ie every tx), as opposed to only updating the metrics once every block. another thing to note, currently doing (1) would require all executor implementations to define the metrics in their own implmentations, meaning have to duplicate code. If do (2) can just define it under `block_producer` scope and be executor agnostic. EDIT: doing (2). metrics are collected upon completion of block production --- some changes are made to gather the value after block production: - simplify params on `backend::do_mine_block`, now only accept two args; `BlockEnv` and `ExecutionOutput` - add a new type `ExecutionStats` under `katana-executor`, this is where executor would store the gas and steps value
matzayonc
pushed a commit
that referenced
this issue
Apr 12, 2024
ref #1791 #1369 <img width="1420" alt="Screenshot 2024-04-12 at 2 36 56 AM" src="https://github.com/dojoengine/dojo/assets/26515232/b97b49df-c5fc-429a-9cb0-bf66138a00b6"> showing total gas and steps using a simple line charts, tracking its growth over time
matzayonc
pushed a commit
that referenced
this issue
Apr 14, 2024
ref #1369 Add metrics on katana executor; tracking the total L1 **gas** and Cairo **steps** used. There were two approaches that i thought of; 1. record the metrics on every tx execution, or 2. on every block ~Decided to go with (1) as it would allow to measure it in realtime (as the tx is being executed), instead of having to wait until the block is finished being processed.~ Thought im not exactly sure which one is the ideal one. Doing (1) might be less performant bcs we have to acquire the lock to the metrics recorder more frequently (ie every tx), as opposed to only updating the metrics once every block. another thing to note, currently doing (1) would require all executor implementations to define the metrics in their own implmentations, meaning have to duplicate code. If do (2) can just define it under `block_producer` scope and be executor agnostic. EDIT: doing (2). metrics are collected upon completion of block production --- some changes are made to gather the value after block production: - simplify params on `backend::do_mine_block`, now only accept two args; `BlockEnv` and `ExecutionOutput` - add a new type `ExecutionStats` under `katana-executor`, this is where executor would store the gas and steps value
matzayonc
pushed a commit
that referenced
this issue
Apr 14, 2024
ref #1791 #1369 <img width="1420" alt="Screenshot 2024-04-12 at 2 36 56 AM" src="https://github.com/dojoengine/dojo/assets/26515232/b97b49df-c5fc-429a-9cb0-bf66138a00b6"> showing total gas and steps using a simple line charts, tracking its growth over time
|
@kariy would consider this as done due to all PRs being merged, please don't hesitate to re-open as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add metrics throughout katana
Tasks
reth-metrics-derivecrate fromdojo-metrics#1719The text was updated successfully, but these errors were encountered: