Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Katana] Adjust account addresses for Starkli #1357

Closed
glihm opened this issue Jan 4, 2024 · 4 comments
Closed

[Katana] Adjust account addresses for Starkli #1357

glihm opened this issue Jan 4, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers katana This issue is related to Katana

Comments

@glihm
Copy link
Collaborator

glihm commented Jan 4, 2024

Is your feature request related to a problem? Please describe.
Starkli has some pre-defined accounts registered for Katana. This allow the user to easily work with katana by mentioning the account index (katana-0, katana-1, ...).

As we now the Katana accounts are V1 accounts, the addresses have changed (even with the seed = 0).

Describe the solution you'd like
Submit a PR in starkli to adjust the built-in accounts for Katana once a new version of Dojo is published with the new accounts.

@glihm glihm added good first issue Good for newcomers katana This issue is related to Katana labels Jan 4, 2024
@0xcoburn
Copy link

0xcoburn commented Jan 6, 2024

whats up brudda @glihm! hope you're doing well, thought I'd start with this one starkli PR

@glihm
Copy link
Collaborator Author

glihm commented Jan 6, 2024

Hello @coburn24 nice to see you around!

How did you get those addresses in the PR? They don't look familiar to me.

Would you mind changing your PR on starkli as a draft, as the v0.4.4 is still using the same addresses. We should wait the v0.4.5 in order to conclude this.

If you want to have the new addresses, please compile on main cargo build -p katana to have them.

Appreciate the contribution on this.

@0xcoburn
Copy link

0xcoburn commented Jan 6, 2024

@glihm I ran dojoup and then katana and got them from v4.4.

@kariy
Copy link
Member

kariy commented Jan 8, 2024

Hey, @coburn24. First of all thanks for spending time contributing on this.

A bug is found in katana #1404 and a fix for it results in a new set of account addresses. Do you mind updating your PR on starkli to reflect this new changes.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers katana This issue is related to Katana
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants