From 2c3d3c242a5a9ad4e1d7c85e0146ef72324bf428 Mon Sep 17 00:00:00 2001 From: lambda-0x <0xlambda@protonmail.com> Date: Fri, 19 Jan 2024 19:40:26 +0530 Subject: [PATCH] update comments --- crates/sozo/src/commands/auth.rs | 1 - crates/sozo/src/commands/events.rs | 1 - crates/sozo/src/commands/execute.rs | 1 - crates/sozo/src/commands/migrate.rs | 3 +-- crates/sozo/src/commands/model.rs | 1 - crates/sozo/src/commands/register.rs | 1 - 6 files changed, 1 insertion(+), 7 deletions(-) diff --git a/crates/sozo/src/commands/auth.rs b/crates/sozo/src/commands/auth.rs index b6584a840b..76b45137c7 100644 --- a/crates/sozo/src/commands/auth.rs +++ b/crates/sozo/src/commands/auth.rs @@ -45,7 +45,6 @@ impl AuthArgs { let env_metadata = if config.manifest_path().exists() { let ws = scarb::ops::read_workspace(config.manifest_path(), config)?; - // TODO: Check the updated scarb way to read profile specific values dojo_metadata_from_workspace(&ws).and_then(|inner| inner.env().cloned()) } else { None diff --git a/crates/sozo/src/commands/events.rs b/crates/sozo/src/commands/events.rs index ffdeb0e564..ca9edd556d 100644 --- a/crates/sozo/src/commands/events.rs +++ b/crates/sozo/src/commands/events.rs @@ -64,7 +64,6 @@ impl EventsArgs { let env_metadata = if config.manifest_path().exists() { let ws = scarb::ops::read_workspace(config.manifest_path(), config)?; - // TODO: Check the updated scarb way to read profile specific values dojo_metadata_from_workspace(&ws).and_then(|inner| inner.env().cloned()) } else { None diff --git a/crates/sozo/src/commands/execute.rs b/crates/sozo/src/commands/execute.rs index 6eeeada678..0a494b1333 100644 --- a/crates/sozo/src/commands/execute.rs +++ b/crates/sozo/src/commands/execute.rs @@ -40,7 +40,6 @@ impl ExecuteArgs { let env_metadata = if config.manifest_path().exists() { let ws = scarb::ops::read_workspace(config.manifest_path(), config)?; - // TODO: Check the updated scarb way to read profile specific values dojo_metadata_from_workspace(&ws).and_then(|inner| inner.env().cloned()) } else { None diff --git a/crates/sozo/src/commands/migrate.rs b/crates/sozo/src/commands/migrate.rs index 7664d5bb8d..649d512241 100644 --- a/crates/sozo/src/commands/migrate.rs +++ b/crates/sozo/src/commands/migrate.rs @@ -14,6 +14,7 @@ use crate::ops::migration; pub struct MigrateArgs { #[arg(short, long)] #[arg(help = "Perform a dry run and outputs the plan to be executed.")] + // TODO: i think dry_run would be more descriptive pub plan: bool, #[arg(long)] @@ -56,8 +57,6 @@ impl MigrateArgs { )?; } - // TODO: Check the updated scarb way to read profile specific values - ws.config().tokio_handle().block_on(migration::execute(&ws, self, target_dir))?; Ok(()) diff --git a/crates/sozo/src/commands/model.rs b/crates/sozo/src/commands/model.rs index c6aa3ad3fa..2056ae9157 100644 --- a/crates/sozo/src/commands/model.rs +++ b/crates/sozo/src/commands/model.rs @@ -67,7 +67,6 @@ impl ModelArgs { let env_metadata = if config.manifest_path().exists() { let ws = scarb::ops::read_workspace(config.manifest_path(), config)?; - // TODO: Check the updated scarb way to read profile specific values dojo_metadata_from_workspace(&ws).and_then(|inner| inner.env().cloned()) } else { None diff --git a/crates/sozo/src/commands/register.rs b/crates/sozo/src/commands/register.rs index 6ff53cdfd6..a1df25a833 100644 --- a/crates/sozo/src/commands/register.rs +++ b/crates/sozo/src/commands/register.rs @@ -45,7 +45,6 @@ impl RegisterArgs { let env_metadata = if config.manifest_path().exists() { let ws = scarb::ops::read_workspace(config.manifest_path(), config)?; - // TODO: Check the updated scarb way to read profile specific values dojo_metadata_from_workspace(&ws).and_then(|inner| inner.env().cloned()) } else { None