Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector: Unexpected behaviour after "select all" followed by a single deselection #293

Open
phil0135 opened this issue Sep 24, 2012 · 3 comments

Comments

@phil0135
Copy link

If all rows have been selected by the header's checkbox and the user deselects a single row, the header checkbox keeps "checked" and the variable "selection" still contains all rows.

I think header checkbox should get state "indeterminate" and selection should only contain values that are actually checked.

This should fix it:
Selection.js

-214:    if(!value) && !this.allSelected){
+214:    if(!value){
+215:     this.allSelected = false; 
          delete this.selection[row.id];
           }else{
      .....
@orontee
Copy link

orontee commented Mar 7, 2013

I confirm the unexpected behavior is still there with last tagged version. What about merging that fix??

@ghost
Copy link

ghost commented Mar 14, 2013

That pull request didn't really get to the root of the issue, so we'll have to take another look at this in the future.

@MikeMcElroy
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants