과제 완료 - 한슬희 #5
Open
과제 완료 - 한슬희 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
reviewed
May 26, 2022
src/Todo.tsx
Outdated
| </form> | ||
| <ul className="listUl"> | ||
| {todos.map((todo: ITodo) => | ||
| <li key={todo.id} className="list"><input type="checkbox"/>{todo.summary}</li> |
There was a problem hiding this comment.
과제에서 요구한 사항은 id까지 렌더링하는 거긴 했는데 !!
src/Todo.tsx
Outdated
| const [newTodos, setNewTodos] = useState<string>(""); | ||
|
|
||
| function onSubmitForm(event: FormEvent<HTMLFormElement>) { | ||
| event?.preventDefault(); |
There was a problem hiding this comment.
여기서는 옵셔널 체이닝이 필요 없을 거 같아요!
Suggested change
| event?.preventDefault(); | |
| event.preventDefault(); |
src/Todo.tsx
Outdated
| } | ||
|
|
||
| function onChangeInput(event: ChangeEvent<HTMLInputElement>) { | ||
| setNewTodos(Object(event.target.value)); |
There was a problem hiding this comment.
여기서 Object 형식으로 wrapping하는 이유가 뭔가요??
newTodos는 string type인데, object 형태로 하신 이유가 있을까요??
src/Todo.tsx
Outdated
|
|
||
| function Todo() { | ||
| const [todos, setTodos] = useState<ITodo[]>([]); | ||
| const [newTodos, setNewTodos] = useState<string>(""); |
There was a problem hiding this comment.
현재 이 state는 추가될 한 가지의 상태의 입력 값을 저장하고 있는 걸로 보여요.
근데 이름이 복수형으로 되어있어 혼란을 야기할 수 있는 이름인 거 같아요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.