Allow creating a saved annotations with the same title #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
chvp
approved these changes
Aug 28, 2023
bmesuere
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to create two saved annotations with the same name.
Instead of crashing on duplicate titles, a warning is now shown.
When saving a new annotation: (The field has a message as title text)
With confirm before save:
When saving an existing annotation:
With confirm before save:
When editing an existing saved annotation:
I have not done a confirm before save on this page. (I can do that but that would probably involve reconverting the page to a webcomponent and reusing the form component to do it properly)
Part of #4564