Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add epub 3.x support,epub 3.x no toc.ncx file #2

Open
ag2s20150909 opened this issue Mar 24, 2021 · 6 comments
Open

please add epub 3.x support,epub 3.x no toc.ncx file #2

ag2s20150909 opened this issue Mar 24, 2021 · 6 comments

Comments

@ag2s20150909
Copy link

please add epub 3.x support,epub 3.x no toc.ncx file

@jiakuan
Copy link
Contributor

jiakuan commented Mar 24, 2021

@ag2s20150909 Good idea. Will check it

@gotson
Copy link

gotson commented Aug 18, 2023

@jiakuan i've experimented with that, but found that working with org.w3c.dom is really painful. Would you consider using JSoup in the project for XHTML parsing ?

@gotson
Copy link

gotson commented Aug 18, 2023

or there might be something to salvage from psiegman/epublib#143

@jiakuan
Copy link
Contributor

jiakuan commented Aug 19, 2023

@gotson Jsoup would definitely be a better option. I will have a look when I get a chance.
Pull requests are welcome and appreciated.

@asm0dey
Copy link
Contributor

asm0dey commented Dec 4, 2024

@jiakuan since I'm already here, maybe I can help with it? Just poke me in the right direction and I'll replace :)

@jiakuan
Copy link
Contributor

jiakuan commented Dec 5, 2024

Here are two tasks:

  1. Replace org.w3c.dom with JSoup to make our lives easier moving forward.
    The first task is quite straightforward: just search and replace the usage with JSoup in a few classes and ensure the tests still work.
Screenshot 2024-12-05 at 09 42 08
  1. Add support for EPUB 3.x.
    You could refer to this PR, though it’s unclear how much we can leverage from it. This task seems more significant and may require arranging a new set of tests for EPUB 3.x functionalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants