From b271c8037960dcb30e74524b83913295779556d1 Mon Sep 17 00:00:00 2001 From: Laura Brehm Date: Mon, 2 Dec 2024 10:50:44 +0000 Subject: [PATCH] tests: cleanup comment Signed-off-by: Laura Brehm --- e2e/container/attach_test.go | 1 - e2e/container/run_test.go | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/e2e/container/attach_test.go b/e2e/container/attach_test.go index a6c9bc04b534..545d86ed707a 100644 --- a/e2e/container/attach_test.go +++ b/e2e/container/attach_test.go @@ -37,7 +37,6 @@ func TestAttachInterrupt(t *testing.T) { // todo(laurazard): make this test work w/ dind over ssh skip.If(t, strings.Contains(os.Getenv("DOCKER_HOST"), "ssh://")) - // if result := icmd.RunCommand("docker", "run", "-d", fixtures.AlpineImage, "sh", "-c", "trap \"exit 33\" SIGINT; for i in $(seq 100); do sleep 0.1; done; exit 34") result.Assert(t, icmd.Success) diff --git a/e2e/container/run_test.go b/e2e/container/run_test.go index b408cc34f1c4..f4e591e21d4d 100644 --- a/e2e/container/run_test.go +++ b/e2e/container/run_test.go @@ -42,10 +42,12 @@ func TestRunAttachedFromRemoteImageAndRemove(t *testing.T) { func TestRunAttach(t *testing.T) { skip.If(t, environment.RemoteDaemon()) + t.Parallel() streams := []string{"stdin", "stdout", "stderr"} for _, stream := range streams { t.Run(stream, func(t *testing.T) { + t.Parallel() c := exec.Command("docker", "run", "-a", stream, "--rm", "alpine", "sh", "-c", "sleep 1 && exit 7") d := bytes.Buffer{} @@ -66,7 +68,7 @@ func TestRunAttach(t *testing.T) { } assert.Equal(t, c.ProcessState.ExitCode(), 7) - assert.Check(t, strings.Contains(d.String(), "exit status 7")) + assert.Check(t, is.Contains(d.String(), "exit status 7")) }) } }