-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: github.com/containerd/console 8f6c4e4 #2238
Conversation
We could test this with client-side integration tests on Windows related to #2206 (comment) |
This comment was marked as outdated.
This comment was marked as outdated.
b057f28
to
f23353a
Compare
@crazy-max would |
No because BuildKit progress ui that buildx depends on also uses |
Ah, gotcha, thx. We really need to look at some of these. I have a feeling we have multiple packages / implementations do very similar things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
left a suggestion (adding a comment to provide context)
full diff: containerd/console@v1.0.3...8f6c4e4 Signed-off-by: CrazyMax <[email protected]>
f23353a
to
6ffb77d
Compare
As discussed internally with @milas @laurazard @thaJeztah, the
containerd/console
terminal check was causing errors to get logged on Windows if the output was redirected (piping to another command withmore
).Bump
github.com/containerd/console
to containerd/console@8f6c4e4 to include containerd/console#66 that fixes this issue.