-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update compose-go to v2.0.0-rc.3 #2205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context path has changed (again) and tests don't expect anymore an absolute path: https://github.com/docker/buildx/actions/runs/7640052586/job/20814449787?pr=2205#step:6:161
This has been changed in #2014 but looks like we need to revert this now with compose-go v2 since it goes to the original and proper behavior. |
Unit tests don't run on Windows on CI (will fix that) but running them on a local Windows machine returns a bunch of test failures related also to context path changes in compose-go v2 which has the opposite behavior of Linux one so seems to be a bug in compose-go:
|
80aabe6
to
844a25f
Compare
done #2206 |
Ok so on unix we have:
on windows:
|
91ebb0f
to
97269be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, we just need to use v2.0.0-rc.3
version of compose-go
before merging
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
97269be
to
5130700
Compare
full diff: compose-spec/compose-go@v1.20.0...v2.0.0-rc.3
Also revert non-deterministic compose context path changes introduced in #2014 but is fixed with compose-go v2.