Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronized option #2

Closed
wants to merge 14 commits into from
Closed

Add synchronized option #2

wants to merge 14 commits into from

Conversation

minRa
Copy link

@minRa minRa commented Apr 7, 2021

No description provided.

@stwiname
Copy link

stwiname commented Apr 7, 2021

Did these changes come from the repo we forked?

{
NSDictionary *query = @{
(__bridge NSString *)kSecClass: (__bridge id)(kSecClassGenericPassword),
(__bridge NSString *)kSecAttrService: service,
(__bridge NSString *)kSecReturnAttributes: (__bridge id)kCFBooleanTrue,
(__bridge NSString *)kSecAttrSynchronizable: (__bridge id)kCFBooleanTrue
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this implicitly make everything synchronised?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like that but I might need a test to make sure it is

@minRa
Copy link
Author

minRa commented Apr 7, 2021

Did these changes come from the repo we forked?

No, it wasn't, I refered to react-native-keychain issue => oblador#156 (comment) and https://developer.apple.com/documentation/security/ksecattrsynchronizable

@developer-darpan developer-darpan self-requested a review April 7, 2021 23:26
@developer-darpan
Copy link

developer-darpan commented Apr 7, 2021

code looks good to me 👍

but, if A & B are synced, and A logs out, then what will happen to B? will it be usable or we need to clear other account-related(non-secure) data from B too?

@minRa
Copy link
Author

minRa commented Apr 7, 2021

code looks good to me 👍

but, if A & B are synced, and A logs out, then what will happen to B? will it be usable or we need to clear other account-related(non-secure) data from B too?

I will test this case once the build has done

@minRa minRa closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants