-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synchronized option #2
Conversation
Did these changes come from the repo we forked? |
{ | ||
NSDictionary *query = @{ | ||
(__bridge NSString *)kSecClass: (__bridge id)(kSecClassGenericPassword), | ||
(__bridge NSString *)kSecAttrService: service, | ||
(__bridge NSString *)kSecReturnAttributes: (__bridge id)kCFBooleanTrue, | ||
(__bridge NSString *)kSecAttrSynchronizable: (__bridge id)kCFBooleanTrue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this implicitly make everything synchronised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like that but I might need a test to make sure it is
No, it wasn't, I refered to react-native-keychain issue => oblador#156 (comment) and https://developer.apple.com/documentation/security/ksecattrsynchronizable |
code looks good to me 👍 but, if A & B are synced, and A logs out, then what will happen to B? will it be usable or we need to clear other account-related(non-secure) data from B too? |
I will test this case once the build has done |
No description provided.