Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor custom function target to take more arguments #51

Open
dmrickey opened this issue Nov 22, 2024 · 0 comments
Open

refactor custom function target to take more arguments #51

dmrickey opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dmrickey
Copy link
Owner

refactor custom target's getSourcesFor to use _getSourcesFor instead so it's not duplicating logic. Also pass the the "this item" to the function to verify things against "this item" (i.e. if this is equipped or something like that which can't be obtained other ways).

Also potentially change signature (would be breaking) so it accepts "item" and/or "action" and "actionUse" individually which is easier for someone to consume to write their own function.

@dmrickey dmrickey added the bug Something isn't working label Nov 22, 2024
@dmrickey dmrickey self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant