Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reuse "save" filename for "export as JSON" #9

Open
rlaemmel opened this issue Jun 9, 2013 · 1 comment
Open

Don't reuse "save" filename for "export as JSON" #9

rlaemmel opened this issue Jun 9, 2013 · 1 comment
Assignees
@dmosen
Labels
clean up

Comments

@rlaemmel
Copy link
Collaborator

rlaemmel commented Jun 9, 2013

This way one can very easily destroy the saved data.
(After all there is no JSON import which in itself is Ok.)
@ghost ghost assigned dmosen Jun 9, 2013
dmosen pushed a commit that referenced this issue Jun 10, 2013
#4,#9 Enforce some reasonable file extension upon save / No reuse of
ca42ded 
filenames on "export as JSON" and "save"

- enforcing ".wikitax", ".json" in ApplicationView and ".csv" in 
TableView
- "export as JSON" uses its own file chooser to prevent accidentally
overwriting. There is also a warning shown if the file to write to
already exists.
@dmosen
Copy link
Owner

dmosen commented Jun 11, 2013

left open for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmosen dmosen

Labels
clean up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlaemmel @dmosen