-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot edit comment of extraction-time excluded categories #6
Comments
Comments for categories that were detected to cause cycles are still not editable.
I'm not sure which ist the most reasonable behaviour to implement. We have three different reasons why a category is excluded:
For every reason it would be important for me to know if:
If we want to distinguish the three possible reasons for exlusion, the data schema (i.e. the graph schema) should be extended. The easiest way is to add another boolean to the schema. If this is done, the export format (json/csv) and maybe the table view has to be supplemented. A drawback of this approach is, that previously saved models have to be patched to be loaded correctly. Nevertheless, commit 43297a0 should help for the meantime. |
No, the commit does not make editable. Yes, I don't mind reason 1. Yes, being able to just edit the comment for reason 2 would be good enough. |
Perhaps you enabled "edit" for the ApplicationView. |
No patching of data models created before this change is necessary
I suggest you worked on a previously saved data model. I did not take this into account, but it should work now. Should it be possible to "unblacklist" categories excluded for reason 2? |
This would be important to fix, as it constrains one to how one can record important observations. Rather a default comment is shown there "excluded on extraction". It may be nice to know whether the exclusion was done during extraction or later, but this should be like a "bit"; this should not fix the comment. The comment should be totally user-definable.
The text was updated successfully, but these errors were encountered: