Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit comment of extraction-time excluded categories #6

Open
rlaemmel opened this issue Jun 9, 2013 · 4 comments
Open

Cannot edit comment of extraction-time excluded categories #6

rlaemmel opened this issue Jun 9, 2013 · 4 comments
Assignees
Labels

Comments

@rlaemmel
Copy link
Collaborator

rlaemmel commented Jun 9, 2013

This would be important to fix, as it constrains one to how one can record important observations. Rather a default comment is shown there "excluded on extraction". It may be nice to know whether the exclusion was done during extraction or later, but this should be like a "bit"; this should not fix the comment. The comment should be totally user-definable.

@ghost ghost assigned dmosen Jun 9, 2013
dmosen pushed a commit that referenced this issue Jun 9, 2013
Comments for categories that were detected to cause cycles are still not
editable.
@dmosen
Copy link
Owner

dmosen commented Jun 9, 2013

I'm not sure which ist the most reasonable behaviour to implement.

We have three different reasons why a category is excluded:

  1. The category causes a cycle (detection happens on extraction)
  2. The category was excluded on extraction
  3. The category was excluded after extraction

For every reason it would be important for me to know if:

  • an "unblacklisting" of the category should be allowed
  • a comment of a category should be editable (As you mentioned, this should be true for reason 2 and 3. About reason 1 I'm not exacly sure.)

If we want to distinguish the three possible reasons for exlusion, the data schema (i.e. the graph schema) should be extended. The easiest way is to add another boolean to the schema. If this is done, the export format (json/csv) and maybe the table view has to be supplemented. A drawback of this approach is, that previously saved models have to be patched to be loaded correctly.

Nevertheless, commit 43297a0 should help for the meantime.

@rlaemmel
Copy link
Collaborator Author

No, the commit does not make editable.

Yes, I don't mind reason 1.

Yes, being able to just edit the comment for reason 2 would be good enough.

@rlaemmel
Copy link
Collaborator Author

Perhaps you enabled "edit" for the ApplicationView.
It is needed for in the "Table" view.

dmosen pushed a commit that referenced this issue Jun 10, 2013
No patching of data models created before this change is necessary
@dmosen
Copy link
Owner

dmosen commented Jun 10, 2013

I suggest you worked on a previously saved data model. I did not take this into account, but it should work now.

Should it be possible to "unblacklist" categories excluded for reason 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants