Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Twin Keepers final version into KFX #3743

Open
elemanzer opened this issue Dec 3, 2024 · 4 comments
Open

Integrate Twin Keepers final version into KFX #3743

elemanzer opened this issue Dec 3, 2024 · 4 comments

Comments

@elemanzer
Copy link
Contributor

KFX uses version 1 of the TK campaign but the author had released 2 updates to this version containing various bugfixes and tweaks. You can still find version 3 here but I've also attached it below since a lot of links on the site are dead.

After comparing v1 vs v3 and testing the need for these changes on KFX, relatively little needs to be integrated and I've already done what I can without touching the KFX improvements:

Script changes:
205. The author added poison & lighning traps for the player.
207. A bug fix for AP5 sometimes not triggering on DK. I couldn't reproduce on KFX but it's probably better to make the trivial change to timer logic.

Flavor text:
The author provided descriptions for some of the levels and these go a long way towards explaining the scripting choices and level mechanics I never even knew existed despite multiple playthroughs of TK. The flavor text (original japanese and translated) is attached below.

  1. Baked the flavor text for 205, 207, 208 into the English .pot of the campaign (205 could use more love)
  2. Also made several corrections and language improvements to the .pot.
  3. Added the flavor text to the .nfo descriptions so someone can do better on (1) in the future.

Map changes:
This I could not get a complete picture of. And since KFX appears to have also done some unspecified processing of all TK maps through adikted, I hope someone with better knowledge on this can integrate the following:

  1. afaict the only change is the green keeper's dungeon layout.
  2. The map has most definitely been changed based on the slab file but I can't for the life of me figure out what was changed.

Please review the required changes.

tk-v3-unmodified.zip
tk-flavor-text.zip
tk-integrated-for-kfx.zip

@Loobinex
Copy link
Member

Loobinex commented Dec 3, 2024

Interesting, especially if there are layout changes. I believe on lubiki we can still find the pre-fx changed version of twin keepers to compare.

@elemanzer
Copy link
Contributor Author

@Loobinex

Both KFX and lubiki appear to be using version 1 of TK since the slb and clm files for both are identical to v1 and the script changes made on v2 and v3 are absent.

@Loobinex
Copy link
Member

Loobinex commented Dec 3, 2024

@Loobinex

Both KFX and lubiki appear to be using version 1 of TK since the slb and clm files for both are identical to v1 and the script changes made on v2 and v3 are absent.

Yes, but KeeperFX made changes to twin keepers, lubiki still has the original version 1 I believe.

@elemanzer
Copy link
Contributor Author

@Loobinex

Right. This is why I compared tkv1 and tkv3 to both lubiki and kfx TK before making the changes. The progression of development of the current kfx TK version was:
original TKv1 > improved by lubiki > lubiki version improved by kfx.

To preserve this evolution and the current kfx improvements to TK, I only made the minimal changes listed in the OP to integrate the level script changes, english pot and description nfos. So the progression changes to
original TKv3 > modified by lubiki > lubiki version modified by kfx > author's flavor text integrated to ENG pot.

The only thing remaining are the modified map layouts in TKv3 levels 207 and 208 but I'm out of my element there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants