Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC events not received in recent master branch Emacs (~February 2019) #61

Open
Jehops opened this issue Mar 8, 2019 · 1 comment
Open

Comments

@Jehops
Copy link

Jehops commented Mar 8, 2019

After upgrading master branch Emacs to 52cd63d1 (20190227) from b32ac17 (20190203), ERC events are not being logged. Here are steps to reproduce the problem.

  1. emacs -Q
  2. Evaluate this code.
(setq sauron-nick-insensitivity 5)
(setq sauron-hide-mode-line t)
(setq sauron-modules '(sauron-erc))

(add-to-list 'load-path "/home/jrm/.emacs.d/elpa/sauron-20181216.1200")

(require 'sauron)
 
(defun jrm/sauron-speak-erc (origin prio msg props)
  "When ORIGIN is erc with priority at least PRIO, say MSG ignoring PROPS."
  (when (eq origin 'erc)
    (call-process-shell-command
     (concat "flite -voice /home/" (user-login-name)
             "/local/share/data/flite/cmu_us_aew.flitevox \"I-R-C message: "
             msg "\"&") nil 0)))

(sauron-start)
  1. Log in to ERC, receive mentions or messages and the only event that is listed in the Sauron buffer is the sauron started event.
@turkja
Copy link

turkja commented Aug 18, 2020

This may be related to what I found when trying Emacs 27.1:
in sauron-erc.el there's a check for erc-version-string, which is not apparently any more a fixed string. I fixed this in sauron-erc-start by changing

(boundp 'erc-version-string)

to

(fboundp 'erc-version)

So instead of checking for fixed version string, check for function returning the version. I don't know if this is correct solution, but so far seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants