Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

Add error test cases #7

Open
djarek opened this issue Oct 13, 2018 · 1 comment
Open

Add error test cases #7

djarek opened this issue Oct 13, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
Boost review ready

Comments

@djarek
Copy link
Owner

djarek commented Oct 13, 2018

Add error test cases (self-signed cert, expired cert, etc.).
@djarek djarek added the enhancement New feature or request label Mar 10, 2019
@djarek djarek added this to the Boost review ready milestone Mar 10, 2019
@djarek
Copy link
Owner Author

djarek commented Mar 10, 2019 •
edited
Loading

Testing is tricky, requires "mocking" out the cert store (which doesn't test all the cases), or a high level test that adds certs to the system store (even trickier).

Windows:
https://github.com/chromium/chromium/blob/468ae9b7d9ec71078d93a5eb162592698256b881/net/cert/cert_verify_proc_win.cc#L933

MacOS
https://github.com/chromium/chromium/blob/90e3ae20e0e37d8dfc0284f2e4974a7a3861b409/net/cert/test_root_certs_mac.cc#L59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Boost review ready
Development

No branches or pull requests
1 participant
@djarek