Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParamSpec includes self for group methods. #73

Open
bckohan opened this issue May 21, 2024 · 2 comments
Open

ParamSpec includes self for group methods. #73

bckohan opened this issue May 21, 2024 · 2 comments
Assignees
@bckohan
Labels
typing Issues involving static type hints.
Milestone
Version 3.0

Comments

@bckohan
Copy link
Member

bckohan commented May 21, 2024

See CommandGroup.get overloads.
@bckohan bckohan added the typing Issues involving static type hints. label May 21, 2024
@bckohan bckohan self-assigned this May 21, 2024
@bckohan
Copy link
Member Author

bckohan commented Nov 23, 2024

This might help:

https://docs.python.org/3/library/typing.html#typing.Concatenate

@bckohan bckohan added this to the Version 3.0 milestone Nov 23, 2024
@bckohan
Copy link
Member Author

bckohan commented Nov 23, 2024

The fix for this makes @group decorators for commands that don't accept a self argument not pass static type checking. This is a fine tradeoff.

bckohan added a commit that referenced this issue Nov 23, 2024
@bckohan
fix #73
f714459
@bckohan bckohan changed the title Fix ParamSpec includes self issue for group methods. ParamSpec includes self for group methods. Nov 24, 2024
bckohan added a commit that referenced this issue Nov 24, 2024
@bckohan
update changelog #73
851a14e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bckohan bckohan

Labels
typing Issues involving static type hints.
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@bckohan