Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use in-house shell completer classes. #156

Open
bckohan opened this issue Dec 4, 2024 · 0 comments
Open

Use in-house shell completer classes. #156

bckohan opened this issue Dec 4, 2024 · 0 comments
Assignees
@bckohan
Labels
BREAKING This change will break downstream code. refactor A code refactor/redesign that does not noticeably effect functionality.
Milestone
Version 3.0

Comments

@bckohan
Copy link
Member

bckohan commented Dec 4, 2024 •
edited
Loading

Typer has repeatably broken shell completion logic and our use case is special enough (i.e. going through a management command so we do not need to rely on environment variables) that it makes more sense to implement the completer scripts and completion logic separately. We should still rely on typer to install the scripts for supported shells though.

This issue will help us bypass upstream problems causing #152
@bckohan bckohan added the refactor A code refactor/redesign that does not noticeably effect functionality. label Dec 4, 2024
@bckohan bckohan added this to the Version 3.0 milestone Dec 4, 2024
@bckohan bckohan self-assigned this Dec 4, 2024
@bckohan bckohan changed the title Take ownership of shell completion logic Use in-house shell completer classes. Dec 4, 2024
@bckohan bckohan added the BREAKING This change will break downstream code. label Dec 9, 2024
bckohan added a commit that referenced this issue Dec 9, 2024
@bckohan
start work on in house shell completer classes #156
1597b0f
bckohan added a commit that referenced this issue Dec 9, 2024
@bckohan
signficant shellcompletion refactor, move to inhouse completer classes,
64f607f 
fix #156
bckohan added a commit that referenced this issue Dec 18, 2024
@bckohan
more work on #156
9312498
bckohan added a commit that referenced this issue Dec 18, 2024
@bckohan
zshell tests working again #156
775fe15
bckohan added a commit that referenced this issue Dec 19, 2024
@bckohan
add tests for terminal formatting in shell completion #156 #152
d6401e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bckohan bckohan

Labels
BREAKING This change will break downstream code. refactor A code refactor/redesign that does not noticeably effect functionality.
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@bckohan