ACE No Med scripted damage compatibilities #140
Conversation
| @@ -0,0 +1 @@ | |||
| [QPATHTOF(functions\fnc_burnSimulation.sqf), QUOTE(DOUBLES(REPLACEMOD,fnc_burnSimulation))] call CBA_fnc_compileFunction; | |||
There was a problem hiding this comment.
what is going on here, why not just use the normal prep macro?
There was a problem hiding this comment.
Replaces an ace function, using the normal prep would just create a new one not used by ace.
There was a problem hiding this comment.
is this file really needed if ace mode handles ace damage already?
| #include "script_component.hpp" | ||
| ADDON = false; | ||
|
|
||
| GVAR(aceMedicalLoaded) = isClass(configFile >> "CfgPatches" >> "ace_medical_engine"); |
There was a problem hiding this comment.
can also exit out early if ace is loaded, as that is already handled by ace itself
| }; | ||
|
|
||
| #include "XEH_PREP.hpp" | ||
| call compile preprocessFileLineNumbers format["%1\XEH_preInit.sqf",REPLACEPATH]; |
There was a problem hiding this comment.
Why do you need to run the ace fire pre init here? Shouldn't it run on its own?
There was a problem hiding this comment.
The config.cpp replaces ace fire's preInit and preStart, and this is specifically replacing a function that would otherwise be locked by cba_compile_function in ace's preStart.
CBATeam/CBA_A3#788 (comment)
| INFO("PreStart: Disabled --> old ACE medical loaded"); | ||
| }; | ||
| #include "XEH_PREP.hpp" | ||
| call compile preprocessFileLineNumbers format["%1\XEH_preStart.sqf",REPLACEPATH]; |
There was a problem hiding this comment.
Same question here, doesn't this run on its own.
addons/compat_ace_fire/config.cpp
Outdated
| #define PATCH_SKIP "ACE Fire" | ||
| #endif | ||
|
|
||
| #ifndef PATCH_SKIP |
There was a problem hiding this comment.
why not just use the else case here, ace fire not loaded will just skip this config completely, including the pre init and pre start eventhandlers
There was a problem hiding this comment.
more clarification, when this is added in the cfgpatches child skipWhenMissingDependencies = 1;
There was a problem hiding this comment.
It's how ACE has their "No Medical" medical skip set up, so I was just copying that.
There was a problem hiding this comment.
Just putting the comment here so it has a focused discussion.
I looked into the ace code to check what is going on. Yeah you need to overwrite and replace the functions, which i frankly do not really like, yet there is no other option right now other than doing some execNextFrame fuckery, which is also fairly ugly.
I will test those changes once i get the chance, but i also would suggest that ACE should get some PR to allow easier handling of these things. So this compats are a lot easier and clearer. I might get on that as well once i get some free time.
Adds compatibility pbos for ACE Fire, Overpressure, and Vehicle Damage, overwriting functions that use setDamage to use diw_armor_plates_main_fnc_receiveDamage instead when armor plates system is enabled, and adding compatibility settings to tweak damage.