Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching types between divviup-client and libprio-rs/janus #897

Open
inahga opened this issue Mar 21, 2024 · 1 comment
Open

Mismatching types between divviup-client and libprio-rs/janus #897

inahga opened this issue Mar 21, 2024 · 1 comment

Comments

@inahga
Copy link
Contributor

inahga commented Mar 21, 2024

In divviup-client, we have types that don't cleanly match those of the janus and libprio-rs crates.

For instance, in Vdaf we have length and bits parameters that need to be converted to usize for use in libprio-rs. Ideally the divviup-client representations would match those of janus and libprio-rs, so the user doesn't need to handle .into()/.try_into()/as conversions.

@inahga
Copy link
Contributor Author

inahga commented Mar 21, 2024

Alternatively we could more closely consider the use cases that users may have for directly using parameters, besides displaying. Maybe it's more useful to have a impl TryInto<prio::vdaf::Collector> for divviup::client::Vdaf that does all integer conversions for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant