-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR -> CSR #15
SSR -> CSR #15
Conversation
@yabe-diverta san |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you provide general loader for fallback?
If you do use ssr: false, you should also place an HTML file in ~/app/spa-loading-template.html with some HTML you would like to use to render a loading screen that will be rendered until your app is hydrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set request changes
@yabe-diverta san Since most of the reviews are related to I agree behaviour-wise while generating there would be no difference between I prefer using
References : |
I thought:
Although,
I could not find that sentence out in doc site, could you share me? |
@yabe-diverta san
Reference |
@VortexExpansion |
@yabe-diverta san
|
@yabe-diverta san |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed, pleas check 🙇
@yabe-diverta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed again, no issues found 🙇
Fixes #14
https://github.com/diverta/front_kuroco_document_site/issues/957
Reviewer
@yabe-diverta san
Key changes
SSR=false
in nuxt configUseFetch
->$fetch
andserver=false
in all API params<ClientOnly>
tag for default.vueProgress check