Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search query params #3

Merged
merged 29 commits into from
Feb 1, 2024
Merged

Conversation

VortexExpansion
Copy link
Collaborator

@VortexExpansion VortexExpansion commented Dec 19, 2023

Issue

https://github.com/diverta/Kuroco-opendev/issues/5176

Reviewer

@yabe-diverta

Points to be reviewed

  • Implement pagination by API in Article page
  • Filter by tag area
  • Filter by tag keyword
  • Filter by search bar
  • Reroute categories into article page.jsx

Links

https://diverta.gyazo.com/f279c096a3afaa0a8dfe2227955124fe

@VortexExpansion VortexExpansion marked this pull request as ready for review December 21, 2023 08:10
@VortexExpansion VortexExpansion changed the title Search query params [WIP] Search query params Dec 21, 2023
@takel-shiba
Copy link
Collaborator

@yabe-diverta
レビュー待ち

@HisashiHasebe HisashiHasebe mentioned this pull request Jan 2, 2024
7 tasks
@HisashiHasebe
Copy link
Collaborator

HisashiHasebe commented Jan 2, 2024

@VortexExpansion
Please check bellow.

【General】

  • remove .env file in PR
  • we cannot comment out output: 'export', in next.config.js. it's necessary for deploy with KurocoFront

【Home page】

【Details page】

【Article page】

【Bug】

@VortexExpansion
Copy link
Collaborator Author

VortexExpansion commented Jan 9, 2024

@HisashiHasebe , @yabe-diverta san

Please review and confirm the changes.

@HisashiHasebe
Copy link
Collaborator

@VortexExpansion
Does the implementation include pagination in this pull request? It is not possible to navigate between pages while maintaining the filters.
https://diverta.gyazo.com/dfe4ecb31e025bc58d02458eee9648d6

@HisashiHasebe
Copy link
Collaborator

HisashiHasebe commented Jan 10, 2024

Please update this.

@VortexExpansion
Copy link
Collaborator Author

@HisashiHasebe
Copy link
Collaborator

@VortexExpansion
Thank you!

And sorry, one more point.
Detail page's header looks difference with mock.
Please check it.

mock:https://diverta.gyazo.com/0d4821eb9dda902e4d63e909d4ede91c
current:https://diverta.gyazo.com/c1a0744bbc113240837e7cafa69726f6

@HisashiHasebe
Copy link
Collaborator

@VortexExpansion
Copy link
Collaborator Author

@HisashiHasebe san

Details page is fixed https://diverta.gyazo.com/7d7ca0a7182e203bb4cd5dea2ddf3bad

I created a new PR for implementing the Top page header animation because that required a change in folder architecture and could have broken other things. #5

@HisashiHasebe HisashiHasebe merged commit 92aa3b8 into diverta:main Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants