Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for openRound #9

Open
madvas opened this issue Jan 25, 2023 · 0 comments
Open

Improvements for openRound #9

madvas opened this issue Jan 25, 2023 · 0 comments
Assignees

Comments

@madvas
Copy link

madvas commented Jan 25, 2023

Better condition here would be: require(roundIsClosed() == true, "Round is already open"); since the round can be closed by expiration as well.

require(roundDuration == 0, "Round is already open");

Additionally openRound should take roundDuration as an argument, instead of hardcoding it for 1 month

function openRound() public onlyAdmin {

EDIT: Sorry I just noticed there are 2 functions openRound and startRound, seems like openRound is redundant so you can remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants