We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better condition here would be: require(roundIsClosed() == true, "Round is already open"); since the round can be closed by expiration as well.
require(roundIsClosed() == true, "Round is already open");
streamtide-smart-contract/streamtide.sol
Line 51 in 5740c35
Additionally openRound should take roundDuration as an argument, instead of hardcoding it for 1 month
openRound
roundDuration
Line 50 in 5740c35
EDIT: Sorry I just noticed there are 2 functions openRound and startRound, seems like openRound is redundant so you can remove it
startRound
The text was updated successfully, but these errors were encountered:
danshinn89
No branches or pull requests
Better condition here would be:
require(roundIsClosed() == true, "Round is already open");
since the round can be closed by expiration as well.streamtide-smart-contract/streamtide.sol
Line 51 in 5740c35
Additionally
openRound
should takeroundDuration
as an argument, instead of hardcoding it for 1 monthstreamtide-smart-contract/streamtide.sol
Line 50 in 5740c35
EDIT: Sorry I just noticed there are 2 functions
openRound
andstartRound
, seems likeopenRound
is redundant so you can remove itThe text was updated successfully, but these errors were encountered: