Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Empty docker images built in some cases by the CI server #685

Open
2 tasks
fbielejec opened this issue Mar 2, 2020 · 0 comments
Open
2 tasks

[BUG] Empty docker images built in some cases by the CI server #685

fbielejec opened this issue Mar 2, 2020 · 0 comments
Assignees
@fbielejec
Labels
bug Something isn't working must have

Comments

@fbielejec
Copy link
Contributor

Description

In some cases CI server builds and releases empty docker images. These are the auto-deployed to the environments and crash immediately after a reboot.
Never images are never picked up since the container under the update watch process is not running at this point.

Expected behavior

If any process exist during the release the whole build should be stopped and failed.

Reproduction

See this build log : https://circleci.com/gh/district0x/memefactory/279

Solution

  • Build artifacts in a separate step
  • Copy them inside the docker images
@fbielejec fbielejec added the bug Something isn't working label Mar 2, 2020
@fbielejec fbielejec self-assigned this Mar 2, 2020
@fbielejec fbielejec changed the title bug/[BUG] [BUG] Empty docker images built in some cases by the CI server Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbielejec fbielejec

Labels
bug Something isn't working must have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbielejec