Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/Memes passing challenge still marked as Stank in Resolved Challenges Tab #668

Open
1 task
pmr212 opened this issue Dec 18, 2019 · 2 comments
Open
1 task
Labels
bug Something isn't working should have

Comments

@pmr212
Copy link

pmr212 commented Dec 18, 2019

User Story

As a user I want memes that receive more dank votes than stank to NOT be marked as stank in the resolved challenges tab.

Description

Type: Bug

Summary:
Submitted meme from account 1.
Challenged meme from account 2.
Voted 3 Dank from account 1.
Voted 2 Stank from account 2.

Meme entered Registry, which was expected. However it has "Stank" banner in resolved challenges tab. Upon further observation, all memes have "Stank" banner in resolved challenges tab.

Expected behavior

Dank memes should not have "Stank" banner

Actual behavior

"Stank" banner is on every meme, including Dank ones.

Reproduction

  • Open webapp
  • Submit meme
  • Challenge meme
  • Vote more dank than stank
  • Observe Resolved Challenges tab

Solution

Summary:

  • Make sure Dank memes are not marked Stank

Additional Information

History of particular meme - https://ropsten.etherscan.io/token/0xeda9bf9199fab6790f43ee21cdce048781f58302?a=0x116f1b759026244afbebce3680ca96ddee4e58be

  • browser console logs: ...
    comment: # (browser version)
  • Browser: Chrome

Logs

...
@pmr212 pmr212 added the bug Something isn't working label Dec 18, 2019
@fbielejec
Copy link
Contributor

This is affecting mainnet (production) only or also QA instance?

@pmr212
Copy link
Author

pmr212 commented Dec 18, 2019

Both QA and mainnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working should have
Projects
None yet
Development

No branches or pull requests

2 participants