Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant matching cap per account #28

Open
Bradymck opened this issue Sep 27, 2023 · 2 comments
Open

Grant matching cap per account #28

Bradymck opened this issue Sep 27, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Bradymck
Copy link
Collaborator

Describe the bug
Currently any account potentially can pull too much from the grant pool in terms of percentage of the total pool.

To Reproduce
Steps to reproduce the behavior:

  1. Create a grant when few others are doing so
  2. Collect donations as an artist
  3. Wait for round to complete when very little competition is present
  4. Win too much of the pool 🤑

Expected behavior
We need a max percentage of grant pool as an admin setting to prevent people from pulling too much to a single account.

Additional context
This needs some thought and we can pull inspiration from how grants stack does it:
https://manager.gitcoin.co/#/round/create?

grants cap

@Bradymck Bradymck added the bug Something isn't working label Sep 27, 2023
@Bradymck
Copy link
Collaborator Author

@madvas I have not thoroughly testing how this works with current model. Would love your 2 bits here.

@ginesdt
Copy link
Contributor

ginesdt commented Sep 27, 2023

@Bradymck this is already in place (sort of). Using the "stars" and "toggles" of the distribute page, you can tune what each user gets from the matching pool.

This was mainly designed to avoid abuses. For example, to avoid that a creator making a lot of small donations to herself gets a big piece of the matching pool cake. However, it can also be used for the purpose you are describing.

If you select 1 out of 3 stars for a user, the maximum of the total pool she can get is 33% regardless of how many donations she received. For 2 out of 3 stars the cap will be 66%, and 3 out of 3 stars they'll have no cap. Additionally, you can manually disable some donations if they do not seem legit so they don't count for the quadratic funding computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants