FIX: TOPIC_NEEDS_EXPERT_POST_APPROVAL should be a boolean

discourse · Dec 7, 2023 · 0a376c8 · 0a376c8
1 parent 9192a5e
commit 0a376c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/category_experts/post_handler.rb b/lib/category_experts/post_handler.rb
@@ -58,7 +58,7 @@ def mark_post_for_approval(skip_validations: false)
       end
 
       if topic.custom_fields[CategoryExperts::TOPIC_EXPERT_POST_GROUP_NAMES].blank?
-        topic.custom_fields[CategoryExperts::TOPIC_NEEDS_EXPERT_POST_APPROVAL] = post.post_number
+        topic.custom_fields[CategoryExperts::TOPIC_NEEDS_EXPERT_POST_APPROVAL] = true
         topic.custom_fields.delete(CategoryExperts::TOPIC_FIRST_EXPERT_POST_ID)
         should_remove_auto_tag = true
       else

diff --git a/plugin.rb b/plugin.rb
@@ -73,7 +73,7 @@ class Engine < ::Rails::Engine
 
   register_topic_custom_field_type(CategoryExperts::TOPIC_EXPERT_POST_GROUP_NAMES, :string)
   register_topic_custom_field_type(CategoryExperts::TOPIC_FIRST_EXPERT_POST_ID, :integer)
-  register_topic_custom_field_type(CategoryExperts::TOPIC_NEEDS_EXPERT_POST_APPROVAL, :integer)
+  register_topic_custom_field_type(CategoryExperts::TOPIC_NEEDS_EXPERT_POST_APPROVAL, :boolean)
   register_topic_custom_field_type(CategoryExperts::TOPIC_IS_CATEGORY_EXPERT_QUESTION, :boolean)
 
   [