Feat/plugin install #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins can now be created as a type of addon adds regexes to convert from a repo or zip to a plugin with a source tests nearly all of the added code.
onerandomusername
added
p: normal
onerandomusername
force-pushed
the
feat/plugin-install
branch
3 times, most recently
from
70cf1a5 to
a023c07
Compare
this is too involved to fix right now Solution involves returning zip files, but the changes to do that require commiting a zipfile, or zipping a zip file before the test. But the contents of that zipfile should be the expected format, so there needs to be several mock files for that. But then they should be in a test resources directory But then the test resources directory should have a few helper methods But then the test resources will need a large amount of review. So the short is, there is a fix for these tests, but it adds a subsystem and is out of scope of this pr.
onerandomusername
force-pushed
the
feat/plugin-install
branch
from
a023c07 to
d96d7a7
Compare
onerandomusername
force-pushed
the
feat/plugin-install
branch
from
a2c61c1 to
550764d
Compare
onerandomusername
force-pushed
the
feat/plugin-install
branch
6 times, most recently
from
6a79437 to
1ebbed3
Compare
|
Linting workflows are going to fail until this is merged with main again due to how github merges then and a dependency mismatch. Given that there's so many merge commits already, I'm holding off on a merge until later. |
onerandomusername
force-pushed
the
feat/plugin-install
branch
from
1ebbed3 to
bb9d3f8
Compare
This reverts commit 1c88421. Not part of the scope of this pr. Also should not have been here but a rebase would change more history than I want to change.
| @@ -0,0 +1,29 @@ | |||
| # NOTICE: This file is automatically generated by scripts/export_requirements.py | |||
There was a problem hiding this comment.
This file may not be needed. Currently discussing internally.
- don't require future annotations in modmail/addons/converters.py
- make all `__all__` tuples
- set score cutoff to a constant in modmail/addons/models.py
- compress if statements
- use {} in place of dict()
- fix typos in some docstrings
- use correct typehints where they are incorrect
- decode the stderr stream only once in pip install
- remove unnecessary logging debug statements
- restructure finding plugins to be easy to be easier to read
- use set() where previously it was {}.
This would cause the variable to be of the wrong type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #74
Relevant Issues
Closes #54
Closes #62
Closes #63
Overview
Installation system for plugins. Portions of this may be used in the future for other addons, so nearly everything up to when the import is done should be in an addons.py utility file.
The currently supported type of repos are in zip format, using the following structure:
This gives the advantage to be able to extend the addons api in the future without having to worry about the structure of the repo.
A sample repository is viewable here: onerandomusername/modmal-addons, with a clone to gitlab/onerandomusername/modmal-addons
Details
Provided a github or gitlab repo, parses it to get the specific plugin information, if it exists, from the plugin.toml file.
The plugin.toml file is supplemental to the folders, meaning that the nature of the toml file existing does not override the existing plugins.
Rather than provide a list of all of the features here, I recommend checking out the documentation for this pull request, found here: https://discord-modmail.readthedocs.io/en/feat-plugin-install/addons/