Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore functionality to display default values for endpoint params #57

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

brotheroftux
Copy link
Contributor

  • Fixed a bug where auto-generated description (with constraint annotation) for endpoint parameters would not get rendered in the resulting markdown.
  • Fixed a bug in constraint annotation concat procedure, where the generator would emit more line terminators than necessary.

Maybe we need some more tests here (should be done in another PR):

  • for all constraints we support
  • for constraint concatenation (since it was still buggy and produced more line terminators than it should)

Constraints implementation is still wacky at times, for example, having a Spec Object like this:

schema:
  type: number
  default: 0

would not produce a readable annotation for default value, since 0 is falsy :)

@brotheroftux brotheroftux changed the title Restore functionality to display default values fior endpoint params Restore functionality to display default values for endpoint params Jun 21, 2024
@brotheroftux brotheroftux merged commit ab77bea into master Jun 27, 2024
2 checks passed
@brotheroftux brotheroftux deleted the DOCSTOOLS-2597 branch June 27, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants