Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged ABIs and proxy contracts #1002

Closed
droserasprout opened this issue Apr 24, 2024 · 3 comments
Closed

Merged ABIs and proxy contracts #1002

droserasprout opened this issue Apr 24, 2024 · 3 comments
Labels
feature New feature or request

Comments

@droserasprout
Copy link
Member

Should we convert EvmContractConfig.abi into tuple?

@droserasprout droserasprout added the feature New feature or request label Apr 24, 2024
@juandiegocv27
Copy link

Hi @droserasprout, can I take thi issue?

@droserasprout
Copy link
Member Author

Hi @juandiegocv27! Thanks for the interest. Actually, this ticket should be split into three:

  1. EVM proxy contracts. Should be a pretty simple task - we have all the necessary data and heuristics is simple too.
  2. Starknet (Cairo) proxy contracts. Much more cases, and we need to implement some logic in Squid Network first.
  3. Merged ABIs. To be honest, I don't understand the use case for this feature, both in general and in our architecture. But it's implemented in Ponder, so I guess it make sense to at least try to understand its role.

Are you interested in Starknet specifically or just want to practice?

Coincidentally, I'm refactoring this part of code right now for the upcoming release. At the moment it's a huge mess and hardly pleasant to contribute to.

@droserasprout
Copy link
Member Author

Closing in favor of #1092, #1093.

@droserasprout droserasprout closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants