From bceadf18536705c1ed0b26b5bc415c68865e75e8 Mon Sep 17 00:00:00 2001 From: Henry Brisson <63800702+henry-brisson@users.noreply.github.com> Date: Sun, 12 Feb 2023 00:19:54 -0500 Subject: [PATCH] feat: Node 18 testing in GH actions (#145) * feat: Node 18 testing in GH actions * Remove cache step and use cache from node action --- .github/workflows/default-node-build.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/default-node-build.yml b/.github/workflows/default-node-build.yml index 9fd1a03b..b9b24e61 100644 --- a/.github/workflows/default-node-build.yml +++ b/.github/workflows/default-node-build.yml @@ -10,7 +10,7 @@ on: node_matrix: description: 'A JSON string of an array of Node versions to run tests on' type: string - default: '["16.x", "17.x"]' + default: '["16.x", "17.x", "18.x"]' # Only upload coverage report for one of the Node versions in the matrix. # Must be present in the matrix. E.g., "17.x" @@ -42,17 +42,11 @@ jobs: with: persist-credentials: ${{ env.HAVE_GITHUB_PAT != 'true' }} - - uses: actions/cache@v3 - with: - path: ~/.npm - key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} - restore-keys: | - ${{ runner.os }}-node-${{ matrix.node-version }}- - - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} + cache: 'npm' - name: Set Private Access Token (if present) run: git config --global url."https://${{secrets.GITHUB_PAT}}@github.com/".insteadOf ssh://git@github.com/