Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling events which do not influence the epidemiology of the disease cause a difference in the number of covid cases at the end of the simulation #28

Open
RobertManningSmith opened this issue Feb 9, 2024 · 1 comment
Assignees

Comments

@RobertManningSmith
Copy link
Collaborator

When creating a test suite for the covid testing and spurious symptom section of the model I found that even when an event does nothing but print out a line of text, this changed the resulting number of cases predicted by the simulation.

This can be seen in the branch redo_testing_from_scratch. The only change to the main code base so far is that a new function (CovidTesting.Testing) is called from the worldbanksimcovid19sim class (line 199). This file only prints out a line of text.

I created a testing file: CovidTestingTesting.java which runs the simulation with and without covidTesting being called, but produces a different total amount of covid infections being created

@RobertManningSmith RobertManningSmith self-assigned this Feb 9, 2024
@swise5
Copy link
Collaborator

swise5 commented Feb 13, 2024

Discussed and confirmed - this is an issue with the fact that the scheduler pulls from the RNG and therefore scheduling a new behaviour (however dummy-tastic) means that the infectious behaviour will encounter different random numbers. We can create a separate RNG to exclusively serve the infectious disease model and not be influenced by scheduling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants