Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning module vs. torch model standardization #230

Open
gumityolcu opened this issue Nov 12, 2024 · 1 comment
Open

Lightning module vs. torch model standardization #230

gumityolcu opened this issue Nov 12, 2024 · 1 comment

Comments

@gumityolcu
Copy link
Collaborator

Currently some classes don't expect a lightning module(ClassDetection benchmark for example) and there are some discrepancies within classes (LDS benchmark should be expecting both and checking that trainer and model objects are both Lightning or both plain torch).

We should go through the code and make sure to unify this

@gumityolcu
Copy link
Collaborator Author

Another example: Metrics require torch.nn.Module but we allow for Benchmarks to pass Lightning modules to metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant