Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ellie example in README.md does not compile #95

Closed
David-Klemenc opened this issue Aug 20, 2021 · 2 comments
Closed

Ellie example in README.md does not compile #95

David-Klemenc opened this issue Aug 20, 2021 · 2 comments

Comments

@David-Klemenc
Copy link

The ellie example does not compile:

Something is off with the body of the `elmUiRenderer` definition:
@quentin
Copy link
Contributor

quentin commented Sep 8, 2021 •
edited
Loading

Duplicates #54

This part is missing in the record built by renderer:

, strikethrough = \content -> Element.row [ Font.strike ] content

and tableCell must be updated to:

, tableCell = \maybeAlignmnent children -> Element.paragraph [] children

quentin added a commit to quentin/elm-markdown that referenced this issue Sep 8, 2021
@quentin
update example in README.md
d4b1e63 
dillonkearns#54
dillonkearns#68
dillonkearns#95
@quentin quentin mentioned this issue Sep 8, 2021
Merged
@dillonkearns
Copy link
Owner

Thanks! These are fixed now with the merged PR from @quentin 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quentin @dillonkearns @David-Klemenc