Skip to content
This repository has been archived by the owner on May 19, 2021. It is now read-only.

Inputfield value empty on mondays #13

Open
samimussbach opened this issue Sep 3, 2013 · 8 comments
Open

Inputfield value empty on mondays #13

samimussbach opened this issue Sep 3, 2013 · 8 comments

Comments

@samimussbach
Copy link
Contributor

Redmine: 2.3.2.stable.12117
Redmine_hours: current git:redmine2

We have a quite weird issue with this plugin.
Whenever we submit times via redmine_hours into a monday textfield (first column) it is saved but not displayed in redmine_hours. In the work_time plugin we can see, that the values are saved, but the doesn't show up in the form fields.

Any idea how I could debug this? I am familiar with programming but not with ruby.

Thank you

@zosiu
Copy link
Contributor

zosiu commented Sep 3, 2013

Maybe it has to do something with the Redmine setting :
Administration -> Settings -> Display -> Start calendars on.
Could you post the value that you use?

Other than this I don't have any specific idea, but if the settings are different (we use Monday), I can experiment a little locally.

@samimussbach
Copy link
Contributor Author

wow this was fast!
It was "Language default" ("Sprachenabhängig"). I played with it but nothing changed. Very strange. Any other Idea? Seems like the first entry of the map is somehow skipped when passing to _weekly.html.erb

@zosiu
Copy link
Contributor

zosiu commented Sep 3, 2013

I don't have any other ideas right now... I'm gonna look at the code and I'll try to reproduce it when I have a little time (probably this evening).

Is this an issue on both screens (weekly/daily) ?

@samimussbach
Copy link
Contributor Author

It occurs on both screens, yes.

It would be great if you'd find some time. Please let me know if I can debug anything for you.

@samimussbach
Copy link
Contributor Author

I have done some debugging on this. When I set hours_controller.rb Line 76 to

weekly_time_entries = TimeEntry.for_user(@user).spent_between(@week_start-1, @week_end)

I get all Issues, included monday, when I leave @week-start without -1, Monday is missing, whatever I do within the calendar settings. Everything else seems to work well with @week-start-1.

I am no ruby programmer, I don't know the possible side effects, perhaps you could investigate it a bit further. I'd be grateful.

@zosiu
Copy link
Contributor

zosiu commented Sep 26, 2013

Ah, now I think I have some ideas for where to look. Thanks for your time spent debugging :)
Anyways I'm planning to refactor/rewrite the whole plugin starting with the next weekend and I will pay attention to this issue too.

@samimussbach
Copy link
Contributor Author

Just curious, any news on the refactoring?

@zosiu
Copy link
Contributor

zosiu commented Nov 8, 2013

My laptop died, it's under repair right now :S

On 8 November 2013 09:09, samimussbach [email protected] wrote:

Just curious, any news on the refactoring?


Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-28044809
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants