Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UP-18 Upgrades error piping #18616

Open
samuel-williams-da opened this issue Mar 1, 2024 · 3 comments · Fixed by #20255, #20289, #20245, #20222 or #20350
Open

UP-18 Upgrades error piping #18616

samuel-williams-da opened this issue Mar 1, 2024 · 3 comments · Fixed by #20255, #20289, #20245, #20222 or #20350
Assignees
@carlpulley-da

Comments

@samuel-williams-da
Copy link
Contributor

samuel-williams-da commented Mar 1, 2024 •
edited by basvangijzel-DA
Loading

Ensure that Dev Upgrade errors make it through canton back to the ledger-api
Pipe lookup errors out of the engine and through canton.

  • Ensure that an invalid variant downgrade gives back a usable error

Ensure that uploadDAR errors (including the type specific error) make it back to the ledger API response. See also #19092.
@samuel-williams-da samuel-williams-da self-assigned this Mar 1, 2024
@basvangijzel-DA
Copy link
Contributor

LookupError and DevError

@basvangijzel-DA
Copy link
Contributor

See #17647

@basvangijzel-DA
Copy link
Contributor

Consider combining 17875

@remyhaemmerle-da remyhaemmerle-da changed the title Upgrades error piping UP-18 Upgrades error piping Oct 23, 2024
This was referenced Nov 6, 2024
Merged
Merged
This was linked to pull requests Nov 21, 2024
UP-18: daml-script upgrade error piping #20255
Merged
UP-18: structured errors for daml-script #20289
Merged
UP-18: Upgrades error piping #20245
Merged
UP-18: ValidationFailed upgrade error migration #20222
Merged
@carlpulley-da carlpulley-da linked a pull request Nov 22, 2024 that will close this issue
UP-18: ledger API split of upgrade errors (Scala changes only) #20350
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlpulley-da carlpulley-da

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@carlpulley-da @basvangijzel-DA @samuel-williams-da