Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused method from Bitfield class #41

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Mar 7, 2024

Bitfield.prototype.clear was never used, so we can remove it.

`Bitfield.prototype.clear` was never used, so we can remove it.
@EvanHahn EvanHahn requested review from gmaclennan and achou11 March 7, 2024 03:25
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could have used this for clearing the index state, but unlinking the storage has the same effect, so fine to remove.

@EvanHahn EvanHahn merged commit 0c4004d into main Mar 13, 2024
4 checks passed
@EvanHahn EvanHahn deleted the remove-unused-bitfield-clear-method branch March 13, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants