feat: Allow adding non-ready cores #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
approved these changes
Nov 27, 2023
gmaclennan
added a commit
that referenced
this pull request
Nov 28, 2023
* WIP change initial state to indexing * fix: initial state is 'indexing' * cache drained state to improve perf * initial state test cleanup * test re-indexing when indexes cleared * test multiple await idle() * switch tests to use new idle() method * add test for mix of empty and filled cores * idle start with no cores, adding core = indexing * fix awaiting idle when already idle * feat: Allow adding non-ready cores (#24) * feat: Allow adding non-ready cores Fixes #23 * run CI on stacked PRs * fix types * rename throttledDrain fn
EvanHahn
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23. Stacked on #22. Changes responsibility for storage creation and closure to CoreIndexStream, and storage is only created once the core is ready.