Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't document onceWriteDoc #25

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: don't document onceWriteDoc #25

merged 1 commit into from
Jan 22, 2024

Conversation

EvanHahn
Copy link
Contributor

indexer.onceWriteDoc was removed in 8caaf6a (#21). This removes its mention in the readme.

git grep -i onceWriteDoc shows no remaining references to this method outside the changelog.

@EvanHahn
fix: don't document onceWriteDoc
ea78553 
`indexer.onceWriteDoc` was removed in
8caaf6a (#21). This removes its
mention in the readme.

`git grep -i onceWriteDoc` shows no remaining references to this method
outside the changelog.
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 7614034472

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7614016832: 0.0%
Covered Lines: 305
Relevant Lines: 305
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7614034472

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7614016832: 0.0%
Covered Lines: 305
Relevant Lines: 305
💛 - Coveralls

@EvanHahn EvanHahn merged commit 36c3333 into main Jan 22, 2024
3 checks passed
@EvanHahn EvanHahn deleted the remove-onceWriteDoc-from-readme branch January 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

@achou11 achou11 Awaiting requested review from achou11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanHahn @coveralls @gmaclennan