Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove onceWriteDoc() #21

Merged
merged 2 commits into from
Oct 26, 2023
Merged

chore!: remove onceWriteDoc() #21

merged 2 commits into from
Oct 26, 2023

Conversation

gmaclennan
Copy link
Member

BREAKING: Fixes #15, this is no longer needed by @mapeo/core,
since this is done outside of the indexer

@gmaclennan
chore!: remove onceWriteDoc()
05aa3fd 
Fixes #15, this is no longer needed by @mapeo/core,
since this is done outside of the indexer
@gmaclennan gmaclennan linked an issue Oct 22, 2023 that may be closed by this pull request
Remove onceWriteDoc() method #15
Closed
@gmaclennan gmaclennan self-assigned this Oct 22, 2023
@gmaclennan gmaclennan requested a review from achou11 October 22, 2023 01:28
@github-actions
Copy link

github-actions bot commented Oct 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6648572099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6648554947: 0.0%
Covered Lines: 287
Relevant Lines: 287
💛 - Coveralls

@gmaclennan
Merge branch 'main' into chore/remove-once-write-doc
d80aa11 
* main:
  feat: revert adding of delete field to schema (#20)
@gmaclennan gmaclennan merged commit 8caaf6a into main Oct 26, 2023
3 checks passed
@gmaclennan gmaclennan deleted the chore/remove-once-write-doc branch October 26, 2023 02:23
EvanHahn added a commit that referenced this pull request Jan 22, 2024
@EvanHahn
fix: don't document onceWriteDoc
ea78553 
`indexer.onceWriteDoc` was removed in
8caaf6a (#21). This removes its
mention in the readme.

`git grep -i onceWriteDoc` shows no remaining references to this method
outside the changelog.
@EvanHahn EvanHahn mentioned this pull request Jan 22, 2024
Merged
EvanHahn added a commit that referenced this pull request Jan 22, 2024
@EvanHahn
fix: don't document onceWriteDoc (#25)
36c3333 
`indexer.onceWriteDoc` was removed in
8caaf6a (#21). This removes its
mention in the readme.

`git grep -i onceWriteDoc` shows no remaining references to this method
outside the changelog.
@coveralls
Copy link

coveralls commented Feb 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 6648572099

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6648554947: 0.0%
Covered Lines: 287
Relevant Lines: 287
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achou11 achou11 achou11 approved these changes

Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove onceWriteDoc() method
3 participants
@gmaclennan @coveralls @achou11