Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert adding of delete field to schema #20

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

gmaclennan
Copy link
Member

The delete field does not actually belong in the indexer, since it does
not change indexer behaviour in any way. Fixes #19

This reverts commit e617aa0.

The delete field does not actually belong in the indexer, since it does
not change indexer behaviour in any way. Fixes #19

This reverts commit e617aa0.
@gmaclennan gmaclennan self-assigned this Oct 22, 2023
@gmaclennan gmaclennan requested a review from achou11 October 22, 2023 01:22
@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Pull Request Test Coverage Report for Build 6600851034

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6381615774: 0.0%
Covered Lines: 328
Relevant Lines: 328

💛 - Coveralls

@gmaclennan gmaclennan merged commit a262d67 into main Oct 26, 2023
3 checks passed
@gmaclennan gmaclennan deleted the chore/revert-delete branch October 26, 2023 02:07
gmaclennan added a commit that referenced this pull request Oct 26, 2023
* main:
  feat: revert adding of delete field to schema (#20)
@coveralls
Copy link

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 6600851034

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6381615774: 0.0%
Covered Lines: 328
Relevant Lines: 328

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert addition of deleted column
3 participants