Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate legacy resampler? #139

Open
Tracked by #143
sbillinge opened this issue Oct 26, 2024 · 2 comments · May be fixed by #180
Open
Tracked by #143

deprecate legacy resampler? #139

sbillinge opened this issue Oct 26, 2024 · 2 comments · May be fixed by #180
Milestone

Comments

@sbillinge
Copy link
Contributor

Problem

there is a legacy resampler in parsers. @Sparks29032 was this from before or did you write this then write a better version. In general, keeping around things that are not used is just technical debt and we should get rid of it.

Proposed solution

If it is something from Pavol days we may want to keep it as other code is likely using it. If we think the code that is using it should start using the wsinterp instead we should deprectate it which means that when it is called we print a warning message that it is deprecated and will be removed in a version two mid-bumps later but should be replaced with wsinterp, then make issues linked to two bumps later to remove it.

@sbillinge
Copy link
Contributor Author

btw, in the past we tended to just remove things, we didn't deprecate properly. There may be nice tools for doing this nicely. We could check.

@sbillinge sbillinge added this to the 3.5.1 release milestone Nov 12, 2024
@Sparks29032
Copy link
Collaborator

Sorry I didn't get pinged for this. Yes, this was from Pavol's time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants