Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookiecutter: modified files pt1 #153

Closed
wants to merge 26 commits into from

Conversation

cadenmyers13
Copy link
Contributor

@sbillinge splitting up the modified files PR

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline comments.

mamba install --file requirements/test.txt
pip install -e .

- name: Use Xvfb Action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need this xvfb action for the wx.

This PR is getting the tests to pass and will take some work, so put all the workflow work on a separate PR. I had it working before with the mamba stuff and we may need to do it that way, but let's try and get as far as we can with the cookiecutter version, then see if we can the xvfb action to work. WHen I was doing it before, it couldn't activate the conda environment for some reason. Let's work on this on a separate PR.

@Sparks29032
Copy link
Contributor

@cadenmyers13 Please merge the PR I sent in before making edits on this branch. These are to fix the deprecations and modify the way we access the date of the package. Yes, it currently uses os rather than Pathlib, but I'm sure the migration should be easy, and I want to get this fix in before my computer blue-screens again. One of my RAM drivers is broken.

@Sparks29032
Copy link
Contributor

The PR migrates pkg_resources and modifies how the daemon is accessed.

@Sparks29032
Copy link
Contributor

Add importlib_resources to build.txt or run.txt. If you add it to build.txt you need to add the line conda install --file requirements/build.txt in the main.yml.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadenmyers13 @Sparks29032 please let me know what to do with this. Merge? or wait.

@Sparks29032
Copy link
Contributor

Let's try getting tests passing on the CI before merging. Hard :(

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Aug 7, 2024

@sbillinge @Sparks29032 since wxpython requires python<=3.11 I changed the required python to be less than 3.12. The CI error now is saying that diffpy.pdfgui requires 3.12.4 (which now isn't available). Ideas on how to fix this?

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadenmyers13 let me know what you want me to do with this PR. Are we working on getting the tests to pass? Do we want to merge some things first and then build a new PR for trouble-shooting the tests? That might seem like a better idea?

@cadenmyers13
Copy link
Contributor Author

@cadenmyers13 let me know what you want me to do with this PR. Are we working on getting the tests to pass? Do we want to merge some things first and then build a new PR for trouble-shooting the tests? That might seem like a better idea?

I agree. Let's get this merged first then start on the CI fix.

@sbillinge
Copy link
Contributor

@cadenmyers13 I'm closing this. Please can you make a clean PR with everything not related to getting the code to run, so just .codecov.yml, .coveragerc, .gitattributes, .gitignore, CHANGELOG.rst, pyproject.toml README.rst then we will go more slowly with the rest.

@sbillinge sbillinge closed this Aug 8, 2024
@cadenmyers13 cadenmyers13 deleted the mod_test branch August 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants