-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookiecutter: modified files pt1 #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see inline comments.
mamba install --file requirements/test.txt | ||
pip install -e . | ||
|
||
- name: Use Xvfb Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need this xvfb action for the wx.
This PR is getting the tests to pass and will take some work, so put all the workflow work on a separate PR. I had it working before with the mamba stuff and we may need to do it that way, but let's try and get as far as we can with the cookiecutter version, then see if we can the xvfb action to work. WHen I was doing it before, it couldn't activate the conda environment for some reason. Let's work on this on a separate PR.
@cadenmyers13 Please merge the PR I sent in before making edits on this branch. These are to fix the deprecations and modify the way we access the date of the package. Yes, it currently uses |
The PR migrates |
Add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cadenmyers13 @Sparks29032 please let me know what to do with this. Merge? or wait.
Let's try getting tests passing on the CI before merging. Hard :( |
@sbillinge @Sparks29032 since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cadenmyers13 let me know what you want me to do with this PR. Are we working on getting the tests to pass? Do we want to merge some things first and then build a new PR for trouble-shooting the tests? That might seem like a better idea?
I agree. Let's get this merged first then start on the CI fix. |
@cadenmyers13 I'm closing this. Please can you make a clean PR with everything not related to getting the code to run, so just .codecov.yml, .coveragerc, .gitattributes, .gitignore, CHANGELOG.rst, pyproject.toml README.rst then we will go more slowly with the rest. |
@sbillinge splitting up the modified files PR