Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookiecutter: doc files #150

Closed
wants to merge 5 commits into from
Closed

Conversation

cadenmyers13
Copy link
Contributor

No description provided.

@cadenmyers13
Copy link
Contributor Author

@sbillinge cookiecutter pt2. This is just adding the doc directory

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. I am guessing that images would probably go into _static. Also th esrc/diffpy/pdfgui/doc

@@ -0,0 +1,194 @@
# Makefile for Sphinx documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we seem to have two Makefiles now. We probably don't need this one (also hte make.bat in here) but look through it as if you were merging this Makefile and the one in source from cookiecutter, and raise any aquestions that come up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I've been basing the structure off diffpy.pdfmorph and diffpy.utils. They both have Makefile directly under doc/. Also, diffpy.pdfmorph still has the make.bat file so wasn't sure if it was still needed here.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something still seems to be wrong here. we don't want doc/source hanging off the _static. The _staic directory is a place where we put all the static files that are needed for the rest. It is kind of like a database where we put images and style files and things we need to build the html later.

A better workflow here would be to initiate a discussion with a small group of people to decide where to put everything. It seems to me that we might want to just have tutorial hanging off doc and all the files needed for tutorial in the tutorial place for example. Include Andrew in that convo as he has good input.

If we have the convo and decide everything, then you can just execute on a clear PR and we can merge it.

@sbillinge
Copy link
Contributor

please see comments in the review.

@sbillinge sbillinge closed this Aug 2, 2024
@cadenmyers13 cadenmyers13 deleted the doc_files branch August 7, 2024 20:38
@Sparks29032
Copy link
Contributor

this looks good. I am guessing that images would probably go into _static. Also th esrc/diffpy/pdfgui/doc

Shoot, missed this. Keep the images in manual, those are images for building the manual specifically. Some of these are generated by the manual scripts that screenshot latex equations for the html to display properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants